[sheepdog-users] dead code?

Dietmar Maurer dietmar at proxmox.com
Fri Jul 20 09:55:07 CEST 2012


> > 	if (msg->cluster_status == SD_STATUS_OK ||
> > 	    msg->cluster_status == SD_STATUS_HALT) {
> > 		if (msg->inc_epoch) {
> > 			uatomic_inc(&sys->epoch);
> > 			log_current_epoch();
> > 		}
> > 		/* Fresh node */
> > 		if (!sys_stat_ok() && !sys_stat_halt()) {
> >
> > Seems this is never triggered, because above condition make sure the
> > one of those flags is always set?
> >
> > - Dietmar
> >
> >
> 
> Why? cluster_status can be WAIT_FOR_JOIN OR WAIT_FOR_FORMAT.

no, because you only reach that statement if (msg->cluster_status == SD_STATUS_OK || msg->cluster_status == SD_STATUS_HALT)

- Dietmar


More information about the sheepdog-users mailing list