[sheepdog-users] Error in processing snapshot name in dog vdi command

[Hitoshi Mitake]

At Tue, 22 Apr 2014 14:31:20 +0000,
Andrew J. Hobbs wrote:
> 
> [1  <text/plain; iso-8859-1 (quoted-printable)>]
> Yes, it needs to start with a non-numeric.  I preface my snapshots with daily- or hourly- to bypass.

The problem is already removed in the latest stable releases.

Thanks,
Hitoshi

> 
> On 04/18/2014 05:15 PM, Scott Devoid wrote:
> I am getting an error with the following command:
> vdi snapshot -s 87cfe950-fada-4cd8-960d-17d9227ff74a_disk_tmp a68a173e-e6f0-414c-b036-c7a09abacbbb -a localhost -p 7000
> 
> Stderr: 'Please specify a non-integer value for a snapshot tag name'
> 
> This is with the 0.6.0 version which has the following for the vdi_parser function (collie/vdi.c):
>     case 's':
>         vdi_cmd_data.snapshot_id = strtol(opt, &p, 10);
>         if (opt == p) {
>             vdi_cmd_data.snapshot_id = 0;
>             pstrcpy(vdi_cmd_data.snapshot_tag,
>                 sizeof(vdi_cmd_data.snapshot_tag), opt);
>         } else if (vdi_cmd_data.snapshot_id == 0) {
>             fprintf(stderr,
>                 "The snapshot id must be larger than zero\n");
>             exit(EXIT_FAILURE);
>         }
>         break;
> 
> 
> The current version looks like this (dog/vdi.c):
>     case 's':
>         vdi_cmd_data.snapshot_id = strtol(opt, &p, 10);
>         if (opt == p || *p != '\0') {
>             vdi_cmd_data.snapshot_id = 0;
>             pstrcpy(vdi_cmd_data.snapshot_tag,
>                 sizeof(vdi_cmd_data.snapshot_tag), opt);
>         } else if (vdi_cmd_data.snapshot_id == 0) {
>             fprintf(stderr,
>                 "The snapshot id must be larger than zero\n");
>             exit(EXIT_FAILURE);
>         }
>         break;
> 
> Based on my reading, this will still have the problem, although my C is quite rusty.
> 
> Thanks,
> ~ Scott
> 
> 
> 
> [2 ajhobbs.vcf <text/x-vcard (base64)>]
> begin:vcard
> fn:Andrew J. Hobbs
> n:Hobbs;Andrew
> org:Delaware State University;Computer and Information Sciences
> adr:;;1200 N Dupont Hwy;Dover;DE;19901;USA
> email;internet:ajhobbs at desu.edu
> title:Lab Coordinator/System Administrator
> tel;work:302-857-7814
> tel;cell:443-359-0122
> x-mozilla-html:TRUE
> url:http://cis.desu.edu
> version:2.1
> end:vcard
> 
> [3  <text/plain; us-ascii (7bit)>]
> -- 
> sheepdog-users mailing lists
> sheepdog-users at lists.wpkg.org
> http://lists.wpkg.org/mailman/listinfo/sheepdog-users