[sheepdog-users] [PATCH stable-0.8] sheep: remove fd leak in vdi deletion process

[Hitoshi Mitake]

At Tue, 28 Jan 2014 13:52:21 +0800,
Liu Yuan wrote:
> 
> On Tue, Jan 28, 2014 at 02:46:17PM +0900, Hitoshi Mitake wrote:
> > The commit 5e460b4d6444 introduced fd leak in the vdi deletion
> > process. This patch removes it.
> > 
> > Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> > Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> > ---
> >  sheep/vdi.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/sheep/vdi.c b/sheep/vdi.c
> > index 6239277..7559421 100644
> > --- a/sheep/vdi.c
> > +++ b/sheep/vdi.c
> > @@ -1147,6 +1147,7 @@ static int start_deletion(struct request *req, uint32_t vid)
> >  	 * deletion_info are deleted
> >  	 */
> >  	eventfd_xread(di->finish_fd);
> > +	close(di->finish_fd);
> >  
> >  	return ret;
> >  out:
> > -- 
> > 1.7.10.4
> 
> Looks good to me

Thanks, but this update doesn't contain manual modifications and
feature backport. So I've already pushed it to stable-0.8.

Thanks,
Hitoshi