[sheepdog-users] client=127.0.0.1:43971, op=DEL_VDI, data=(not string)

[MORITA Kazutaka]

At Wed, 5 Mar 2014 00:49:58 +0800,
Liu Yuan wrote:
> 
> On Tue, Mar 04, 2014 at 05:27:40PM +0100, Marcin Mirosław wrote:
> > Hi!
> > I found in log something like this:
> > Mar 04 17:07:33   INFO [main] rx_main(775) req=0x7fcb380008c0,
> > fd=20, client=127.0.0.1:43343, op=MAKE_FS, data=(not string)
> > Mar 04 17:07:33   INFO [main] tx_main(827) req=0x7fcb380008c0,
> > fd=20, client=127.0.0.1:43343, op=MAKE_FS, result=00
> > Mar 04 17:07:43   INFO [main] rx_main(775) req=0x7fcb380008c0,
> > fd=20, client=127.0.0.1:43350, op=NEW_VDI, data=(not string)
> > Mar 04 17:07:43   INFO [main] tx_main(827) req=0x7fcb380008c0,
> > fd=20, client=127.0.0.1:43350, op=NEW_VDI, result=00
> > Mar 04 17:20:54   INFO [main] rx_main(775) req=0x7fcb280008c0,
> > fd=15, client=127.0.0.1:43971, op=DEL_VDI, data=(not string)
> > Mar 04 17:20:55   INFO [main] tx_main(827) req=0x7fcb280008c0,
> > fd=15, client=127.0.0.1:43971, op=DEL_VDI, result=00
> > 
> > It looks data_to_str() returns "return "(not string)"". Shoud I
> > expect to e.g. "data=<name of vdi>"?
> > $ sheep -v
> > Sheepdog daemon version 0.8.0_108_g21fc658_dirty
> > 
> > Marcin
> 
> You are not the only one who complains about this. I am along with you that
> I think these information is non-user-friendly, which was introduced to mean
> give user more information about what every opeation admins might execute.

I agree on that the log messages should me more informative for users.

Thanks,

Kazutaka