[sheepdog-users] [sheepdog] fix bug 1317791

[Valerio Pachera]

2014-09-04 12:42 GMT+02:00 Ruoyu <liangry at ucweb.com>:

>
> In your opinion, duplicated tag name should be forbidden once user tries
> to create a snapshot for the vdi?
> If yes, it is not difficult. I will take care of it.
>
>
Because we can refer to a snapshot by id and by tag, I think tag has to be
unique as the id.
I guess sheepdog in its internal operation uses only the snapshot id but,
situations like the one below, make me wonder what's going to happen till I
tried it first.

dog vdi list
  Name        Id    Size    Used  Shared    Creation time   VDI id  Copies
Tag
s test         1  1.0 GB  1.0 GB  0.0 MB 2014-09-04 14:19   7c2b25
2           xxx
s test         2  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b26
2           xxx
s test         3  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b27
2           xxx
s test         4  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b28
2           xxx
s test         5  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b29
2           xxx
  test         0  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b2a
2

dog vdi delete -s xxx test

dog vdi list
  Name        Id    Size    Used  Shared    Creation time   VDI id  Copies
Tag
s test         1  1.0 GB  1.0 GB  0.0 MB 2014-09-04 14:19   7c2b25
2           xxx
s test         2  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b26
2           xxx
s test         3  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b27
2           xxx
s test         4  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b28
2           xxx
  test         0  1.0 GB  0.0 MB  1.0 GB 2014-09-04 14:19   7c2b2a      2

Before patching, evaluate if there may be any impact in the cluster
snapshot save:
dog vdi snapshot -s xxx test
dog cluster snapshot save tag1 path
dog vdi delete -s 1 test
# later on
dog vdi snapshot -s xxx test
dog cluster snapshot save tag2 path

I this example, both cluster snapshots are storing the vdi with the same
tag.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wpkg.org/pipermail/sheepdog-users/attachments/20140904/b8c41155/attachment-0004.html>