At Fri, 21 May 2010 13:40:31 +0200, Kevin Wolf wrote: > > Am 20.05.2010 07:36, schrieb MORITA Kazutaka: > > This patch enables protocol drivers to use their create options which > > are not supported by the format. For example, protcol drivers can use > > a backing_file option with raw format. > > > > Signed-off-by: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp> > > Hm, this is not stackable, right? Though I do see that making it > stackable would require some bigger changes, so maybe we can get away > with claiming that this approach covers everything that happens in practice. > > If we accept that this is the desired behaviour, the code looks good to me. > As you say, this patch isn't stackable; we must specify a image name with at most 1 format and 1 protocol. I cannot think of a situation where we want to use more than one protocol to create qemu images, so this seems to be enough to me. Thanks, Kazutaka |