[Sheepdog] [PATCH 5/5] Remove unused vosts structure

Steven Dake sdake at redhat.com
Mon May 17 22:56:42 CEST 2010


The vosts structure is unused and not set, resulting in a potential segfault
if the eprintf code is executed.  Another alternative is to set vosts[x] but
I am not certain what it should be set to.

Signed-off-by: Steven Dake <sdake at redhat.com>
---
 sheep/sdnet.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sheep/sdnet.c b/sheep/sdnet.c
index f1ce8ea..79ba3ff 100644
--- a/sheep/sdnet.c
+++ b/sheep/sdnet.c
@@ -510,7 +510,6 @@ int write_object(struct sheepdog_node_list_entry *e,
 {
 	struct sd_obj_req hdr;
 	int i, n, fd, ret, success = 0;
-	uint16_t vosts[3];
 	char name[128];
 
 	for (i = 0; i < nr; i++) {
@@ -522,7 +521,7 @@ int write_object(struct sheepdog_node_list_entry *e,
 
 		fd = connect_to(name, e[n].port);
 		if (fd < 0) {
-			eprintf("can't connect to vost %u, %s\n", vosts[i], name);
+			eprintf("can't connect to vost %s\n", name);
 			continue;
 		}
 
@@ -543,7 +542,7 @@ int write_object(struct sheepdog_node_list_entry *e,
 		ret = exec_req(fd, (struct sd_req *)&hdr, data, &wlen, &rlen);
 		close(fd);
 		if (ret)
-			eprintf("can't update vost %u, %s\n", vosts[i], name);
+			eprintf("can't update vost %s\n", name);
 		else
 			success++;
 	}
-- 
1.6.2.5




More information about the sheepdog mailing list