[Sheepdog] [PATCH] farm: fix configure error checking SHA1_Init

[Liu Yuan]

On 12/29/2011 01:43 AM, Dongsu Park wrote:

> In configure.ac, libcrypto should be checked instead of libssl,
> as SHA1_Init() cannot be found in libssl.so since libssl v1.0.
> That's why configure didn't run on my Ubuntu precise system.
> 
> Signed-off-by: Dongsu Park <dongsu.park at profitbricks.com>
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4d5a7e1..d72c051 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -263,8 +263,8 @@ if test "x${enable_accord}" = xyes; then
>  fi
>  
>  if test "x${enable_farm}" = xyes; then
> -	AC_CHECK_LIB([ssl], [SHA1_Init],,
> -		AC_MSG_ERROR(libssl not found))
> +	AC_CHECK_LIB([crypto], [SHA1_Init],,
> +		AC_MSG_ERROR(libcrypto not found))
>  	AC_CHECK_HEADERS([openssl/sha.h],,
>  		AC_MSG_ERROR(sha.h header missing))
>  	AC_CHECK_LIB([z], [deflate],,


Thanks for your patch, but did you consider compatibility with old systems?

On my system with libssl-0.9.8, with your patch works, but I am unsure
of older systems with it.

By the way, since farm is still under heavy development, not merged, if
you don't mind, I'd like to take your patch as a comment instead of a
patch that triggers a commit and add your signed-off in the patch.

Thanks,
Yuan