[Sheepdog] [PATCH] sheep: unify create_and_write logic for cow and regular object
Christoph Hellwig
hch at infradead.org
Tue Nov 15 09:02:44 CET 2011
On Tue, Nov 15, 2011 at 03:47:20PM +0800, Liu Yuan wrote:
> From: Liu Yuan <tailai.ly at taobao.com>
>
> store_create_and_write_obj_cow() and store_create_and_write_obj() share
> a lot of logic, it is neat to unify them.
Err, I just split them exactly because they don't share any logic. The
only think shared are the calls to ob_open and store_write_obj_fd, but
any actual logic is different.
> - use fallocate() for cow object creation too.
Why? We write the whole object in one go, so this shouldn't make
a difference.
More information about the sheepdog
mailing list