On Tue, May 1, 2012 at 12:03 AM, Christoph Hellwig <hch at infradead.org> wrote: > On Mon, Apr 30, 2012 at 04:53:47PM +0800, Liu Yuan wrote: >> From: Liu Yuan <tailai.ly at taobao.com> >> >> - for vdi create operation, if we have less available nodes for >> desired redundancy, simply fail-returen. So no need to change >> copies into nr_zones. >> - for delete_one, let's keep its origin logic as before commit: >> ad8c5cf6495 > > As suggested by Kazum I think stopping to deal with inode->nr_copies > and all passing around of it probably is the best thin we can do in > this area for now. > I think this patch is need to make sure that we don't create VDI when the copies aren't promised. Speaking of 'this area', did you mean 'different VDI redundant level' feature? If so, it is very nice of you to have this feature implemented. But I think that should be a different patch set, if you are fine with this patch, I'm going to merge it. Thanks, Yuan |