[Sheepdog] PATCH S003: Handle master crashing before sending JOIN request

MORITA Kazutaka morita.kazutaka at gmail.com
Mon Apr 30 11:23:43 CEST 2012


At Sun, 29 Apr 2012 02:05:33 +0800,
Liu Yuan wrote:
> 
> No, your patch is completely wrong workaround, not a fix. You just set
> every node as 'first node' and all nodes become the master and send the
> response to each other.

I think you misunderstand Shevek's patch.  IIUC, there is no situation
that multiple nodes become the master at the same time with his patch.

Shevek's patch is relatively straightforward.  If you think it is
hacky, what should be blamed is 'first_node' in the corosync_event
structure, which is introduced by me.

I like Christoph's version:
  http://lists.wpkg.org/pipermail/sheepdog/2012-April/003186.html
Yuan, what do you think of it?

Thanks,

Kazutaka



More information about the sheepdog mailing list