[Sheepdog] [PATCH 3/3] sheep: fix nr_copies in vdi.c

Christoph Hellwig hch at infradead.org
Mon Apr 30 19:21:11 CEST 2012


On Tue, May 01, 2012 at 12:22:56AM +0800, Liu Yuan wrote:
> I think this patch is need to make sure that we don't create VDI when
> the copies aren't promised.
> 
> Speaking of 'this area', did you mean 'different VDI redundant level'
> feature? If so, it is very nice of you to have this feature
> implemented.

The idea is to remove it until we have it properly implemented, as
suggest by Kazutaka - leaving in fragments of unimplemented
functionality is bound to cause the confusion we have right now.  I'd
actually love to put it back rather sooner or later, but it needs to be
done properly.

> But I think that should be a different patch set, if you
> are fine with this patch, I'm going to merge it.

The patch you sent just passes the "copies" argument on to read_object
and write_object calls.  I think that's incorrected because my earlier
patched move the ceiling for it from these functions into the caller.
I think that's what the patch I sent does, but I'm at a conference and
still jetlagged, so please double check it.




More information about the sheepdog mailing list