On Mon, Aug 13, 2012 at 04:14:03PM +0800, Liu Yuan wrote: > From: Liu Yuan <tailai.ly at taobao.com> > > We should wait all the sheep to join completion before issuing any collie > command > > - add a helper _wait_for_sheep_join(nr_sheep) Looks good, but again please add a comment explaining it. I'd also suggest to rename it, probably just _wait_for_sheep, while the comment explains that we want them joined. |