On Thu, Aug 16, 2012 at 10:29 AM, Liu Yuan <namei.unix at gmail.com> wrote: > On 08/16/2012 02:36 AM, Yunkai Zhang wrote: >> From: Yunkai Zhang <qiushu.zyk at taobao.com> >> >> > > For such a big patch, commit log is very important: you should briefly > describe the new algorithm and the benefit. > > The biggest problem of this patch is that we lose the capability to > repair the consistency, which is actually more important. We should have > a means to restore cluster objects into consistent state. After learned this tool's background, I would keep the original command, but add a '--no-repair' option because I needn't to repair in some case, for example: we don't know which copies of object is correct. > > Thanks, > Yuan -- Yunkai Zhang Work at Taobao |