On 2012年08月24日 14:41, MORITA Kazutaka wrote: > At Fri, 24 Aug 2012 14:30:42 +0800, > levin li wrote: >> >> I think SD_NR_VDIS is big enough, it can contain up to 2097152 >> vdi copy entries, 2097152 VDIs are more than enough for our cluster, >> and by this we don't need to allocate the 128M memory for such >> a request, what do you think about it? > > I think the right way is: > - allocate a small size (e.g. 4 MB) > - iterate SD_OP_GET_VDI_COPIES until reading all copies > > But the implementation would be a bit complicated. How about > allocating SD_DATA_OBJ_SIZE bytes and leave it as TODO like > SD_OP_GET_OBJ_LIST for now? > > Thanks, > > Kazutaka > OK, agreed, I'd update this patch. thanks, levin |