[sheepdog] bug: Invalid free space size '0': must be an integer between 0

[levin li]

On 08/05/2012 09:05 PM, Jens WEBER wrote:
> testing new features, gateway-only do not start
> 
> with -g sheep crashes, so I try -s 0 and get
> 
> Invalid free space size '0': must be an integer between 0 and 18446744073709551615
> *                case 's':
> *                        free_space = strtoll(optarg, &p, 10);
> *                        if (optarg == p || free_space <= 0 ||
> *                            UINT64_MAX < free_space) {
> *                                fprintf(stderr, "Invalid free space size '%s': "
> *                                        "must be an integer between 0 and %lu\n",
> *                                        optarg, UINT64_MAX);
> *                                exit(1);
> 
> -g sets sys->disk_space = 0; <- I think that caused the problem later
> *        if (nr_vnodes == 0) {
> *                sys->gateway_only = 1;
> *                sys->disk_space = 0;
> *        }
> 
> Thanks, Jens
> 
Sheep doesn't allow user to specify disk space size to 0, for gateway-only mode, use -g
argument directly, but sorry, I can not reproduce the crash bug as you described, it works
well in my environment:

+ collie/collie node list -p 7000
M   Id   Host:Port         V-Nodes       Zone
-    0   127.0.0.1:7000      	27          0
-    1   127.0.0.1:7001      	54          1
-    2   127.0.0.1:7002      	110          2
-    3   127.0.0.1:7003      	 0          3

as the output above, node with Id 3 is a gateway-only node.

Can you give the crash log ?

thanks,

levin