[sheepdog] [PATCH] farm: fix comparison of empty sha1

Liu Yuan namei.unix at gmail.com
Tue Aug 7 14:07:48 CEST 2012


On 08/07/2012 07:55 PM, MORITA Kazutaka wrote:
> If the first byte of entry->raw.sha1 is zero, strlen(entry->raw.sha1)
> returns zero.  What this function wants to do is to check
> entry->raw.sha1 is filled with zero, isn't it?

Yes, your fix looks okay but I thought you have met some segfault like problem
caused by this line,

-- 
thanks,
Yuan



More information about the sheepdog mailing list