[sheepdog] [PATCH V2 00/11] INTRODUCE

Yunkai Zhang yunkai.me at gmail.com
Mon Aug 13 07:35:37 CEST 2012


On Mon, Aug 13, 2012 at 10:29 AM, Liu Yuan <namei.unix at gmail.com> wrote:
> On 08/09/2012 04:43 PM, Yunkai Zhang wrote:
>> - fix a typo
>> - when an object is updated, delete it old version
>> - reset cluster recovery state in finish_recovery()
>
> You should brief what your patch set does in the introduction cover
> letter. I have no idea what your INTRODUCE means. Please complete your
> title too.
>
> What is use case to delay LEAVE event (why we need such complexity)? How

I suppose the reviewers already know my previous patchsets(delay JOIN
event) because we have been discussed in detail with Kazum and other
users about the benefit of delay LEAVE event. I just don't want to
type it again, you can learn its background from this mail thread:
http://lists.wpkg.org/pipermail/sheepdog/2012-July/005684.html

If you consist to rewrite this cover letter, I can update it in next version.

> to use? This is the most important arguments you should include in the
> cover letter to defend your patch set and let people think it is useful.
>
> Thanks,
> Yuan



-- 
Yunkai Zhang
Work at Taobao



More information about the sheepdog mailing list