[sheepdog] [PATCH 1/7] test: fix 011 to umount the right mountpoint

Liu Yuan namei.unix at gmail.com
Mon Aug 13 13:02:12 CEST 2012


On 08/13/2012 06:39 PM, Christoph Hellwig wrote:
> On Mon, Aug 13, 2012 at 04:13:58PM +0800, Liu Yuan wrote:
>>      for i in 0 1 2; do
>> -        umount $STORE/$i.img
>> -	rm -f $STORE/$i.img
>> +        umount $STORE/$i
>> +        rm -f $STORE/$i.img
> 
> What version of umount doesn't handle calling it with the backing image
> as argument?
> 
> I'm fine with changing it, but a more detailed description would be
> useful as the above umount syntax works for me.
> 

Without this patch, I get the following error:

tailai.ly at taobao:~/sheepdog/tests$ sudo ./check 011
PLATFORM      -- Linux/x86_64 taobao 2.6.35-32-generic

011 8s ... - output mismatch (see 011.out.bad)
--- 011.out	2012-08-13 16:02:36.172727029 +0800
+++ 011.out.bad	2012-08-13 19:00:40.352847431 +0800
@@ -12,3 +12,6 @@
 -    0   127.0.0.1:7000      	27          0
 -    1   127.0.0.1:7001      	55          1
 -    2   127.0.0.1:7002      	110          2
+umount: /tmp/sheepdog/0.img: not mounted
+umount: /tmp/sheepdog/1.img: not mounted
+umount: /tmp/sheepdog/2.img: not mounted
Failures: 011
Failed 1 of 1 tests
tailai.ly at taobao:~/sheepdog/tests$ umount --version
umount (util-linux-ng 2.17.2)

Thanks,
Yuan



More information about the sheepdog mailing list