[sheepdog] [PATCH v4 01/10] sheep: use struct vdi_iocb to simplify the vdi_create api

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Mon Aug 20 06:53:20 CEST 2012


At Thu,  9 Aug 2012 13:27:36 +0800,
levin li wrote:
>  
> +struct vdi_iocb {
> +	char *data;

Should be "char *name"?

> +	uint32_t data_len;
> +	uint64_t size;
> +	uint32_t base_vid;
> +	int is_snapshot;

Should be "bool is_snapshot"?

> +	int nr_copies;
> +};
> +

Can we use this structure to lookup_vdi() and del_vdi(), too?

Thanks,

Kazutaka



More information about the sheepdog mailing list