[sheepdog] [PATCH V2 1/4] collie: add private options to collie's command

Yunkai Zhang yunkai.me at gmail.com
Thu Aug 23 11:04:56 CEST 2012


On Thu, Aug 23, 2012 at 3:47 PM, Liu Yuan <namei.unix at gmail.com> wrote:
> On 08/21/2012 10:09 PM, Yunkai Zhang wrote:
>>  collie/cluster.c | 24 ++++++++++++++++++------
>>  collie/collie.c  | 49 +++++++++++++++++++++++++------------------------
>>  collie/collie.h  |  1 +
>>  collie/vdi.c     | 56 ++++++++++++++++++++++++++++++++++++++++----------------
>
> I'd like to merge this patch first because it is really useful. It seems
> that you don't change debug.c,node.c. Could you split this patch out of
> series and repost it with changes to debug.c and node.c?

We need not to update debug.c and node.c, because they share the
common options defined in collie_options structure.

This patch split options into two parts:
1) Common options, which will be shared with all commands.
2) Private options, only for some commands if they need.


>
> Thanks,
> Yuan



-- 
Yunkai Zhang
Work at Taobao



More information about the sheepdog mailing list