[sheepdog] [PATCH 3/3] sheep: split notification messages into two queues

[Liu Yuan]

On 08/31/2012 12:16 PM, MORITA Kazutaka wrote:
> At Fri, 31 Aug 2012 12:10:56 +0800,
> Liu Yuan wrote:
>>
>> On 08/31/2012 11:44 AM, MORITA Kazutaka wrote:
>>> IIUC, the zookeeper driver doesn't use a different queue for confchg
>>> events, so this patch doesn't affect the driver at all.  Using a
>>> single queue means that the zookeeper driver cannot pass test 026, but
>>> it's another problem to be fixed.
>>>
>>
>> Yunkai has a fix for zookeeper, which tries to process LEAVE event only
>> when there is blocking event. So seems that your patch won't affect it.
>> I am going to apply this patch. But I'd hope that we can test zookeeper
>> driver in the tests too.
>>
>> Yunkai, would you please spend sometime to enable our test framework
>> also to test zookeeper driver?
> 
> We can set a cluster driver with an environment variable:
> 
>   $ env DRIVER="zookeeper:[host]:[port]" ./check
> 

Ah, thanks. But still we need changes to the code and test scripts to
run zookeeper drivers:
 1) add a timeout option for zookeeper (we need a short timeout such as
1s to run test scripts)
 2) rework zookeeper driver to remove the constraint that we have to
start master node firstly before start other nodes.

I have dirty-patched the code and script 026 to run with zookeeper
driver, it passes 026. So your patch to split pending list looks to work
with zookeeper.

I hope someday we can run zookeeper driver smoothly.

Thanks,
Yuan