[sheepdog] [PATCH v3] lib: prioritize events for epoll() and enhance event loop

Hitoshi Mitake h.mitake at gmail.com
Mon Dec 24 07:34:18 CET 2012


At Mon, 24 Dec 2012 10:23:18 +0800,
Liu Yuan wrote:
> 
> On 12/23/2012 11:57 PM, Hitoshi Mitake wrote:
> >  sheep/cluster/accord.c    |    6 ++-
> >  sheep/cluster/corosync.c  |    4 +-
> >  sheep/cluster/local.c     |    4 +-
> >  sheep/cluster/zookeeper.c |    8 ++-
> >  sheep/request.c           |   33 +++++++++------
> >  sheep/sheep.c             |    6 ++-
> >  sheep/trace/trace.c       |   16 ++++---
> >  sheep/work.c              |    6 ++-
> 
> Since sheep doesn't use it, then we shouldn't change the other
> functions. This patch should only add event_loop_prio() only. We'd
> better modify *affected* code on demand when you really begin to use
> event_loop_prio(). Also you seem to forget the documentation
> EVENT_LOOP_XXX again.

The changes for other functions are required because this patch
changes the type of event handlers.

But... I could find that it is possible to implement keeper without
this patch. So please discard this patch for now. If this feature is
seriously required by sheep or keeper, I'd like to refine and post it
again.

Thanks,
Hitoshi



More information about the sheepdog mailing list