On 01/05/2012 04:27 AM, MORITA Kazutaka wrote: > This patch has style problems. Use tabs instead of spaces where > possible. > >> - change global store structure to a pointer >> - use a list to maintain the stores. >> - use /obj/.store to remember backend store persistently. > > How about writing the backend driver name into 'config'? Sheepdog > uses the file to store global info. Ah, yea. > How about sending the driver name instead of its index? Then, we > don't need to maintain consistency between index_to_name() and > get_store_index(). Yes, but seems that struct sd_so_req only have 7 bytes available, we have some limit to name the store driver, in assumption we don't create a new sd_xx_req struct. Thanks, Yuan |