On Wed, Jul 11, 2012 at 10:50 AM, Yunkai Zhang <yunkai.me at gmail.com> wrote: > On Wed, Jul 11, 2012 at 10:23 AM, Liu Yuan <namei.unix at gmail.com> wrote: >> On 07/11/2012 01:31 AM, Yunkai Zhang wrote: >>> Please see the previous patch's description. >> >> I don't review the code yet, just some suggestions: >> >> We should directly write commit log instead of a pointer to the place >> you'll definitely forget in days. >> >> Also, 'fix bug when processing blocked event' is not informative at all. >> You should briefly write what your patch really fixes. For e.g, >> >> 'cluster/corosync: fix double call to sd_block_handler' > > Ok, I'll give a v2. With a second thought, accord seems not have this issue, I give up this patch. > > >> >> We can get the idea what the patch does. >> >> Thanks, >> Yuan > > > > -- > Yunkai Zhang > Work at Taobao -- Yunkai Zhang Work at Taobao |