On 07/13/2012 04:47 PM, Christoph Hellwig wrote: > On Wed, Jul 11, 2012 at 06:11:31PM +0800, Liu Yuan wrote: >> This patch also remove request throttling because we are guaranteed to process >> requests as soon as it arrives and won't block any request. > > I don't even understand the reason for blocking_conn_list, even with > epoll + O_NONBLOCK I/O we should not have to have an artifical limit > like that. > With short thread, this isn't needed at all, cause requests are never blocked. > How do the numbers look if you compare just removing > MAX_OUTSTANDING_DATA_SIZE to your full patch? > I think this macro matters nothing to the performance, it should be never reached for now. I'll go to patch a separate patch to remove it. Thanks, Yuan > Also if you move TX/RX to threads anyway why not simply stick to > blockin I/O instead of using epoll in the main thread and then creating > a new thread on every even? > |