On 07/19/2012 10:19 AM, levin li wrote: > From: levin li <xingke.lwp at taobao.com> > > v2 --- > v3: > 1. add some comments > 2. rename objlist_cache_delete to objlist_cache_cleanup > > v1 --- > v2: > 1. rename 'reclaim' to 'deletion' > 2. add some comments > > Object list cache does not take too much memory, so reclaiming seems > unnecessary, but there's a problem: > > Objects belonging to a deleted VDI does not exist any more, but the > associated entries still stay in the cache list, so if a recovery > happens, sheep would try to recovery these objects and of cause this > would cause many object recovery failure, and waste resource. > > > levin li (4): > sheep: notify VDI deletion to all nodes when deleting a VDI > object list cache: put all the cache entry into a list > object list cache: reclaim object list cache when receiving a > deletion event. > farm: comment why we can't remove objlist entry while deleting object > > include/internal_proto.h | 1 + > sheep/farm/trunk.c | 56 ++++++++++++++++++++++------------ > sheep/object_list_cache.c | 74 +++++++++++++++++++++++++++++++++++++++++++-- > sheep/ops.c | 14 +++++++++ > sheep/sheep_priv.h | 2 ++ > sheep/vdi.c | 52 +++++++++++++++++++++++++++++-- > 6 files changed, 173 insertions(+), 26 deletions(-) > Any comments to this patchset ? thanks, levin |