At Tue, 24 Jul 2012 11:09:22 +0800, Liu Yuan wrote: > > On 07/24/2012 10:31 AM, MORITA Kazutaka wrote: > > But it might be a matter of taste. I'm not against it if you think it > > is useful. > > How about changing it to FDS_SIZE? If we follow the Linux kernel coding style strictly, I think the macro should be #define FDS_SIZE(x) (sizeof(struct sockfd_cache_fd) * (x)) or #define fds_size(x) (sizeof(struct sockfd_cache_fd) * (x)) But I prefer the latest patch which don't use a macro. I'll merge it. Thanks, Kazutaka |