[sheepdog] [PATCH 2/2] accord: fix bug when processing blocked event

Liu Yuan namei.unix at gmail.com
Wed Jul 11 04:23:25 CEST 2012


On 07/11/2012 01:31 AM, Yunkai Zhang wrote:
> Please see the previous patch's description.

I don't review the code yet, just some suggestions:

We should directly write commit log instead of a pointer to the place
you'll definitely forget in days.

Also, 'fix bug when processing blocked event' is not informative at all.
You should briefly write what your patch really fixes. For e.g,

'cluster/corosync: fix double call to sd_block_handler'

We can get the idea what the patch does.

Thanks,
Yuan



More information about the sheepdog mailing list