[sheepdog] [PATCH 1/3] sheep: split object_cache_rw

Liu Yuan namei.unix at gmail.com
Mon Jul 16 08:03:42 CEST 2012


On 07/14/2012 03:39 PM, Christoph Hellwig wrote:
> On Fri, Jul 13, 2012 at 08:13:02PM +0800, Liu Yuan wrote:
>>> -static int object_cache_rw(struct object_cache *oc, uint32_t idx,
>>> -			   struct request *req)
>>> +static int object_cache_write_int(struct object_cache *oc, uint32_t idx,
>>> +		struct request *req)
>>>  {
>>
>> Maybe you mean object_cache_write_ent()?
> 
> _int as in "internal"  If you want a different name I'd be happy to
> change it.
> 

Int just reminds me of 'integer' for a first look. Would be nice to use
a more descriptive and unambiguous name.

Thanks,
Yuan




More information about the sheepdog mailing list