[Sheepdog] Fix to put_sha1_file

Liu Yuan namei.unix at gmail.com
Fri Mar 2 10:51:37 CET 2012


On 03/02/2012 05:11 PM, huxinwei wrote:

> Hi list:
> 
> I found an panic in sheep today.
> 
> Mar 02 23:57:28 fill_entry_new_sha1(178) data
> sha1:5e630c602d8e18e3ee6643670ddd4a671e5ee922, 8071d67a00000000 Mar
> 02 23:57:28 omap_file_insert(265) nr is 488 Mar 02 23:57:28
> trunk_file_write(315) try delete stale snapshot object
> 8071d67a00000000, with data sha1:
> 5d5d171fca6bf63a0b6a0f4db2c7367b8b48bf9b Mar 02 23:57:28
> put_sha1_file(92) No such file or directory
> 
> It happens when the sheep is killed after omap_file_init but before
> omap_file_final, and some of the staled snapshot have been unlinked. 
> Then sheep will always panic every time afterward.
> 
> The patch is a proposal to make put_sha1_file tolerant
> not-exist-file.
> 
> FYI.


Hi, Xinwei,
	Good catch. For patch submitting, it would be nice to add a prefix to
the patch title and your sign-off at the end of the patch
description(used as a commit log when being applied). git format-patch
is recommended to generate patch. Because this will reduce the
modification of the mbox-style patch to apply.

Applied after modifying the patch title and add your sign-off to the end
of the commit log.

Yuan
thanks.



More information about the sheepdog mailing list