On 04/29/2012 07:47 PM, Christoph Hellwig wrote: >> - if (inode->name[0] != '\0') >> + if (inode->name[0] != '\0'&& vid != dw->vid) >> goto out; > This change causes the breakage for me. I can't find any rationale for > it in the changelog, so I really wonder what it is for. > > Please describe your patches better in the changelog in the future, and > improve test coverage of them. > In the old code, sheep firstly clear the name of a vdi to be deleted, and then to start the deletion work, what I did in this patch is to make sheep clear the vdi name after the deletion work has been done, so here the inode name of the deleting vdi hasn't been cleared, so we should check whether the vdi in the path is the vdi to be deleted. |