At Tue, 01 May 2012 14:23:16 +0800, Liu Yuan wrote: > > > And, probably, you should remove object_cache code from sheep/store.c > > in this patch. > > > > > No, I don't think so. The object cache implementation is already > encapsulated into object_cache.c. Both bypass_object_cache() and > handle_gateway_request() are higher level code that just make use of > object cache. So I think it would be better to leave them in the store.c The subject of this patch is "object list cache: move it out of store.c", but you only add the code to sheep/object_list_cache.c. You don't remove the code from sheep/store.c in this patch but in f29b10. I'm not sure why you did so, but it's okay for now since the patches are already merged. Thanks, Kazutaka |