On Wed, May 02, 2012 at 03:18:01AM +0900, MORITA Kazutaka wrote: > > The big question is if we want to limit it by sys->nr_copies too, my > > patch did that because it makes little sense to create an object with > > more redudancy if system objects like the inode don't have it. I think > > If nr_copies has a larger value than inode->nr_copies, it should be a > bug. Right now they always should be the same, but in an environmen where we allow setting a different level for VDI it could be lower. > Ideally, sys->nr_copies should be used only when setting > inode->nr_copies in the case the user doesn't specify it. > So I think allowing higher redundancy doesn't make much difference > since sheep doesn't need to know the default redundancy level when > processing I/Os, no? We'll need sys->nr_copies for reading the inode initially at least. |