On Mon, May 14, 2012 at 11:27 PM, Christoph Hellwig <hch at infradead.org>wrote: > I have looked over the patch a bit more and I think there is an issue > in it as it decouples the epoch update formerly in __sd_leave_done > from the vnode information update the line below - it seems like we > might now hit a window where the vnode has alreayd been incremented > by operations still operate on the old vnode confifuration. But at > least to me it seems like we could update the vnode configuration > earlier, too. > Your are right. > > another thing I noticed is that I think your patch makes the ->dispatch > cluster driver operation obsolete. Once we never register the event > handler for the cluster driver FD it can be handled netirely inside the > cluster driver, e.g. just call register_event from inside the init > method and don't even tell the core about it. > We have called register_event(cdrv_fd, ...) in create_cluster(). -- Yunkai Zhang Work at Taobao -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.wpkg.org/pipermail/sheepdog/attachments/20120515/d7077823/attachment.html> |