At Sun, 20 May 2012 10:39:51 -0400, Christoph Hellwig wrote: > > On Sun, May 20, 2012 at 11:27:33PM +0900, MORITA Kazutaka wrote: > > @@ -312,7 +312,7 @@ static int local_get_store_list(struct request *req) > > list_for_each_entry(driver, &store_drivers, list) { > > strbuf_addf(&buf, "%s ", driver->name); > > } > > - memcpy(req->data, buf.buf, buf.len); > > + memcpy(req->data, buf.buf, buf.len + 1); > > Can we add a strbuf_copyout helper to avoid this bitfall for other > users? Yes, I'll send the patch soon. Thanks, Kazutaka |