On 05/25/2012 10:22 PM, Christoph Hellwig wrote: > On Fri, May 25, 2012 at 10:31:00AM +0800, levin li wrote: >> From: levin li <xingke.lwp at taobao.com> >> >> We should not make gateway retry in check_request when the >> requested object is in recovery, we should make it retry in >> io_op_done(), gateway request does not access local objects, >> so we should not make it retry when the local objects are in >> recovery. > > This patch seems to break the following simple test case that reads > from a newly started sheep because it can't find the object yet: > > sheep -p 7000 /tmp/sheep/0 > collie cluster format --copies=1 > collie vdi create test-vdi 300M > dd if=/dev/zero count=100M | collie vdi write tet-vdi > > sheep -p 7001 /tmp/sheep/1 > collie vdi read -p 7001 > I tested with your script, and make it run on my computer like this: sheep -d -p 7000 /tmp/sheep/0 -z 0 collie cluster format -c 1 collie vdi create test-vdi 300M dd if=/dev/zero count=100M | collie vdi write test-vdi sheep -d -p 7001 /tmp/sheep/1 -z 1 collie vdi read -p 7001 test-vdi 0 100M I got a error message: Cannot get VDI info for test-vdi 0 : Waiting for cluster to be formatted Failed to open VDI test-vdi But, even though I popup all the patches in the patch set, it still give that error message, I think it's another problem, or maybe it's not a bug at all, because later I try to run 'collie vdi read -p 7001 test-vdi 0 100M' again, it works well. thanks, levin |