On Fri, May 25, 2012 at 9:46 PM, Christoph Hellwig <hch at infradead.org>wrote: > I like this idea, but there's a few more things that should be > investigated in this area: > > 1) shouldn't the recovery code use struct vnode_info through the code? > 2) given that we know the old epoch configuration before starting > recovery shouldn't we just pass the old and new one in through > start_recovery? > Getting new and old nodes/vnodes need read data from disk. It should occur at recovery thread. IMHO, we should not pass them to start_recovery. There are other files calling vnode_info besides group.c now. If the calling need not read fields of vnode_info, there is no error. Perhaps we can use vnode_info in recovery structure directly and not use sd_vnodes any more. Then the vnode_info definition can remain at group.c. Thanks Haiti -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.wpkg.org/pipermail/sheepdog/attachments/20120528/58275761/attachment.html> |