[sheepdog] a question about epoch_log_read_remote

Christoph Hellwig hch at infradead.org
Tue May 22 17:37:57 CEST 2012


What is the intended use of epoch_log_read_remote?

There are two callers of it, local_stat_cluster and get_vnodes_from_epoch,
and both only call it after epoch_log_read failed (in the second case
indirected via epoch_log_read_nr), but the first thing
epoch_log_read_remote does is to call epoch_log_read again to find the
remote nodes to connect to to get a node list.  Even worse
epoch_log_read_remote returns 0 even if epoch_log_read failed, thus
making error handling basically impossible.



More information about the sheepdog mailing list