[Sheepdog] [PATCH 1/3] sheep: clean up is_access_to_busy_objects()

MORITA Kazutaka morita.kazutaka at gmail.com
Wed May 2 06:38:02 CEST 2012


At Wed, 02 May 2012 12:28:17 +0800,
Liu Yuan wrote:
> 
> On 05/02/2012 12:11 PM, MORITA Kazutaka wrote:
> 
> > I think it's better to call panic() and print the error reason here.
> 
> 
> Why we need this extra guard? it is not a general API, but just a
> internal API, we should trust callers and push responsibility to the
> caller too.

It will check the function is correctly called with new changes in
future.  Probably assert() would be better.

Thanks,

Kazutaka



More information about the sheepdog mailing list