[Sheepdog] [PATCH 1/2] add oid_to_vnodes() and obj_to_sheeps() to avoid too much vnodes traverse
Liu Yuan
namei.unix at gmail.com
Tue May 15 05:28:58 CEST 2012
On 05/15/2012 12:52 AM, Christoph Hellwig wrote:
> Either way these functions seem to large to be inlined to me, even
> before your changes. Can we move them into out of lines functions
> to get better caching behaviour? Especially with the many callers that
> might actually make a difference.
I think inline is okay, we have 32KB code L1 cache, big enough to hold
these two function. These two function are often called in a loop, so
we'd benefit from remove function call overhead.
Thanks,
Yuan
More information about the sheepdog
mailing list