[sheepdog] [PATCH] sheep: set sys->epoch correctly before becoming master

Liu Yuan namei.unix at gmail.com
Sun May 20 17:33:14 CEST 2012


On 05/20/2012 10:37 PM, Christoph Hellwig wrote:

> On Sun, May 20, 2012 at 11:39:20PM +0900, MORITA Kazutaka wrote:
>> This fixes a bug introduced by commit 43a2f684e, and necessary to pass
>> the following testcase:
>>
>>   #!/bin/bash
>>   set -ex
>>
>>   for i in 0 1 2; do ./sheep/sheep /store/$i -z $i -p 700$i; sleep 1; done
>>   ./collie/collie cluster format
>>   for i in 0 1 2; do pkill -f "sheep /store/$i"; sleep 1; done
>>   for i in 1 0 2; do ./sheep/sheep /store/$i -z $i -p 700$i; sleep 1; done
>>   for i in 0 1 2; do ./sheep/sheep /store/$i -z $i -p 700$i; sleep 1; done
>>   for i in 0 1 2; do ./collie/collie cluster info -p 700$i; done
> 
> Indeed.  Thanks for the fix and I'll make sure to test for this in the
> future.
> 


Hmmm, it seems that we are badly in need of a working test suite to find
out such regressions. How is it going, Christoph? I remember that you
said you were working on it.H

Thanks,
Yuan



More information about the sheepdog mailing list