[sheepdog] [PATCH] zookeeper: hande node joining race

[Christoph Hellwig]

On Mon, May 28, 2012 at 11:54:32PM +0800, Yunkai Zhang wrote:
> On Mon, May 28, 2012 at 11:25 PM, Christoph Hellwig <hch at infradead.org> wrote:
> > I got a bug report where the nr_sd_nodes == nr_zk_nodes assert in
> > build_node_list is trigger by a larger number of sheep joining at the same
> > time.
> 
> We should not start sheeps at the same time. Are you read this commit log from
> this patch:8567aae281c75502c0a267bf76b771a2af8392f2 ?

No, I generally do not read commit logs to find excuses for bugs.

Even if starting sheep fast wasn't something you thougt about initially:

 a) it should be documented in the source tree in a comment or
    documentation file
 b) be handled gracefully instead of hitting an assert.