[sheepdog] [PATCH] sheep: don't call check_request() from resume_pending_requests
levin li
levin108 at gmail.com
Tue May 29 13:28:30 CEST 2012
On 05/29/2012 07:04 PM, Christoph Hellwig wrote:
> On Tue, May 29, 2012 at 06:54:45PM +0800, Liu Yuan wrote:
>> From: Liu Yuan <tailai.ly at taobao.com>
>>
>> It seems that we can pass the scripts without this patch, I think
>> this line brings much problems (nested request manipulation) than
>> it sovles.
>
> Even if my original issue is not reproducable I don't think it's safe.
> There's no guarantee a busy object is not marked busy by the time
> resume_pending_requests is called.
>
Indeed there's no such guarantee, but maybe we can just check whether
the requested object is busy in resume_pending_requests() instead of calling
check_request() to make things more complicated.
thanks,
levin
More information about the sheepdog
mailing list