[sheepdog] [PATCH UPDATE] make recovery not to retry when recover_object_from_replica() fail

Liu Yuan namei.unix at gmail.com
Wed May 30 06:00:56 CEST 2012


On 05/30/2012 11:57 AM, levin li wrote:

> -	buf = malloc(buf_size);
> +	buf = xmalloc(buf_size);
>  	if (!buf) {
>  		eprintf("out of memory\n");
> -		rw->retry = 1;
>  		return -1;
>  	}


No need to check retval for xmalloc(), it will simply panic when no
memory is allocated. I think we really should panic if recovery doesn't
take place.

Thanks,
Yuan



More information about the sheepdog mailing list