[sheepdog] [PATCH v2 3/3] sheepkeeper: a new cluster manager specialized for sheepdog

Hitoshi Mitake h.mitake at gmail.com
Mon Nov 12 12:59:19 CET 2012


On Mon, Nov 12, 2012 at 7:06 PM, Liu Yuan <namei.unix at gmail.com> wrote:
> On 11/12/2012 04:58 PM, Hitoshi Mitake wrote:
>> +             ret = xwrite(sk_comm_fd, &snd, sizeof(snd));
>> +             if (ret != sizeof(snd)) {
>> +                     vprintf(SDOG_ERR, "xwrite() failed\n");
>> +                     exit(1);
>> +             }
>
> Actually you don't need check xwrite/xread and their friends. They will
> handle the error case internally.
>

Thanks for your pointing. In this situation, using xread/xwrite should
be avoided.
Because sheeps and sheepkeepers have a possibility of death by hardware failure.

I'll fix this problem in the v3.

Thanks,
Hitoshi



More information about the sheepdog mailing list