[sheepdog] [PATCH v3 1/2] sheep: introduce journal file to boost IO performance
Liu Yuan
namei.unix at gmail.com
Tue Nov 13 10:11:37 CET 2012
On 11/13/2012 05:10 PM, MORITA Kazutaka wrote:
> At Mon, 12 Nov 2012 14:09:31 +0800,
> Liu Yuan wrote:
>>
>> On 11/12/2012 01:08 PM, Liu Yuan wrote:
>>> +static bool journal_descriptor_valid(struct journal_descriptor *jd)
>>> +{
>>> + if (jd->magic != JOURNAL_DESC_MAGIC)
>>> + return false;
>>> + if (jd->oid == 0)
>>> + return false;
>>
>> Well, can OID be 0? I'm not quit sure about this.
>
> Probably, no. I think we can safely remove it.
>
you mean remove jd->oid == 0 safe guard?
Thanks,
Yuan
More information about the sheepdog
mailing list