[sheepdog] [PATCH] collie: remove invalid fallthrough in option parser of vdi

Hitoshi Mitake mitake.hitoshi at lab.ntt.co.jp
Fri Oct 26 09:45:28 CEST 2012


The fallthrough in vdi_parser() seems a bug.

Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
---
 collie/vdi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/collie/vdi.c b/collie/vdi.c
index e0581b8..f18f789 100644
--- a/collie/vdi.c
+++ b/collie/vdi.c
@@ -1953,6 +1953,7 @@ static int vdi_parser(int ch, char *opt)
 			exit(EXIT_FAILURE);
 		}
 		vdi_cmd_data.nr_copies = nr_copies;
+		break;
 	case 'F':
 		vdi_cmd_data.from_snapshot_id = strtol(opt, &p, 10);
 		if (opt == p) {
@@ -1960,6 +1961,7 @@ static int vdi_parser(int ch, char *opt)
 			strncpy(vdi_cmd_data.from_snapshot_tag, opt,
 				sizeof(vdi_cmd_data.from_snapshot_tag));
 		}
+		break;
 	}
 
 	return 0;
-- 
1.7.2.5




More information about the sheepdog mailing list