[sheepdog] [PATCH] disk cache: drop O_DSYNC only when O_DIRECT is set

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Oct 30 01:49:56 CET 2012


At Thu, 25 Oct 2012 13:52:01 +0900,
MORITA Kazutaka wrote:
> 
> To make sure that data is not cached by the host os, we cannot drop
> O_DSYNC when O_DIRECT is not set.
> 
> Signed-off-by: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
> ---
>  sheep/plain_store.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

I would drop this patch since dropping a page cache with posix_fadvise
looks better than adding O_DSYNC flag.  I'll send the patch later.

Thanks,

Kazutaka



More information about the sheepdog mailing list