[sheepdog] [PATCH V4 2/2] collie: optimize 'collie vdi check' command

[Yunkai Zhang]

On Mon, Sep 3, 2012 at 7:03 PM, Liu Yuan <namei.unix at gmail.com> wrote:
> On 09/03/2012 06:54 PM, Yunkai Zhang wrote:
>> We can compare this result with comand line tools: sha1sum, which can
>> also help us to verify program's correction I think.
>
> Could you specify a use case for this? I have no idea how end users can
> make use of sha1 string. For a crashed cluster, I think want users need
> to do is, run check to restore cluster consistency by one command like fsck.

Our root problem is just why we need to move sha1_to_hex from
farm/sha1_file.c to lib/sha1.c, does this change bother you?

Show sha1 string will make the output more meaningful for us, why need
to a use case? It's a so small/simple thing, do you like argue
everything?

>
> Thanks,
> Yuan



-- 
Yunkai Zhang
Work at Taobao